This repository was archived by the owner on Oct 10, 2019. It is now read-only.
Bug report and bugfix for problem with invalid characters in thrown exception#1
Closed
slavo2 wants to merge 3 commits intoklarna:masterfrom
Closed
Bug report and bugfix for problem with invalid characters in thrown exception#1slavo2 wants to merge 3 commits intoklarna:masterfrom
slavo2 wants to merge 3 commits intoklarna:masterfrom
Conversation
- fix for problem with (possibly) invalid characters in thrown exception
Contributor
|
Thanks for your PR, I will take a look at it. |
Klarna.php
Outdated
Contributor
There was a problem hiding this comment.
private methods should be prefixed with an underscore.
…oding() and updated: support for intl, mbstring and iconv php extensions fallback to ASCII using regular expression possibility to specify input and output encoding as method arguments
Author
|
I have renamed and updated the private method (now:) Klarna::_fixMessageEncoding() |
Contributor
|
We're working on getting this repo into composer. As soon as that is done, I'll look into getting your stuff merged. |
Author
|
Hi Joakim I have already made a composer package from your SDK Slavo |
Author
|
Alternative (and possibly better) solution provided in pull request #3 |
JoakimLofgren
added a commit
that referenced
this pull request
Jun 3, 2015
…o v4.0 * commit '4f6ce70b1ada0a7d3a4c6f880016fb4af77ea494': (21 commits) Remove unused exceptions Update doc comments Add composer script for references Update README with shields for composer Update license to Apache 2.0 Update changelog Add composer script for zip package Fix pcStorage name to class name Bump version Fix codesniffer lint errors Deprecate checkoutHTML method Update author doc comment Update examples to use autoloader Install phpxmlrpc dependency via composer Enable class autoloading via composer Split out exceptions into separate files Rename filenames to match class names Move source files into src/ directory Move examples into docs/ folder Add a composer.json file ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug description:
KlarnaException which can be attempted to be thrown at line of 3669 of Klarna.php might contain possibly invalid characters from incorrectly interpreted faultString().
Bug fix:
Converting the character encoding of the message before being used in constructing KlarnaException by adding and using method Klarna::fixMessageEncoding()